Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how the SDK parses NGINX API server directive #423

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

dhurley
Copy link
Collaborator

@dhurley dhurley commented Aug 1, 2023

Proposed changes

Updated parseAddressesFromServerDirective function to return multiple possible addresses.
See here for more info on the listen directive http://nginx.org/en/docs/http/ngx_http_core_module.html#listen

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 82fc344
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/64c92194894ad700081f5f01

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies labels Aug 1, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.08% ⚠️

Comparison is base (996d150) 67.57% compared to head (82fc344) 67.49%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
- Coverage   67.57%   67.49%   -0.08%     
==========================================
  Files         113      113              
  Lines       12766    12778      +12     
==========================================
- Hits         8627     8625       -2     
- Misses       3569     3584      +15     
+ Partials      570      569       -1     
Files Changed Coverage Δ
...or/github.com/nginx/agent/sdk/v2/config_helpers.go 68.89% <100.00%> (+0.56%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhurley dhurley added bug Something isn't working and removed dependencies chore Pull requests for routine tasks labels Aug 2, 2023
@dhurley dhurley merged commit 9101da2 into main Aug 8, 2023
28 checks passed
@dhurley dhurley deleted the update-parser-for-nginx-api branch August 8, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants