Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cert directives for ssl_client_certificate and ssl_trusted_certificate #430

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

CodeMonkeyF5
Copy link
Contributor

@CodeMonkeyF5 CodeMonkeyF5 commented Aug 9, 2023

Proposed changes

Add support for the ssl_client_certificate and ssl_trusted_certificate directives to treat them the same as ssl_certificate and ssl_proxy_certificate. Certificates managed in NMS can then appropriately display the associations for NGINX Instance and Instance Groups when configured.

This change is required to complete the expected end-to-end behaviors.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Aug 9, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit f9e2f84
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/64d3c8b378c446000831dabd

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies enhancement New feature or request labels Aug 9, 2023
@CodeMonkeyF5 CodeMonkeyF5 changed the title feat: cert directives for ssl_client_certificate and ssl_trusted_certificate enhancement: cert directives for ssl_client_certificate and ssl_trusted_certificate Aug 9, 2023
@CodeMonkeyF5 CodeMonkeyF5 changed the title enhancement: cert directives for ssl_client_certificate and ssl_trusted_certificate feat: cert directives for ssl_client_certificate and ssl_trusted_certificate Aug 9, 2023
@CodeMonkeyF5 CodeMonkeyF5 changed the title feat: cert directives for ssl_client_certificate and ssl_trusted_certificate chore: cert directives for ssl_client_certificate and ssl_trusted_certificate Aug 9, 2023
@dhurley dhurley removed enhancement New feature or request dependencies labels Aug 14, 2023
@oliveromahony oliveromahony merged commit 29985e7 into main Aug 15, 2023
28 checks passed
@oliveromahony oliveromahony deleted the ppfrehm/extend_cert_directives_for_ssl branch August 15, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants