Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how status API URL is determined when both stub status and NGINX Plus APIs are configured #433

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

dhurley
Copy link
Collaborator

@dhurley dhurley commented Aug 14, 2023

Proposed changes

Fix how status API URL is determined when both stub status and NGINX Plus APIs are configured.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 4812798
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/64da0539f80f1f000890571b

@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks dependencies labels Aug 14, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 22.98% and project coverage change: -0.46% ⚠️

Comparison is base (7cc0918) 67.48% compared to head (4812798) 67.03%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
- Coverage   67.48%   67.03%   -0.46%     
==========================================
  Files         113      113              
  Lines       12777    12838      +61     
==========================================
- Hits         8623     8606      -17     
- Misses       3584     3662      +78     
  Partials      570      570              
Files Changed Coverage Δ
src/core/nginx.go 45.86% <0.00%> (-0.54%) ⬇️
...or/github.com/nginx/agent/sdk/v2/config_helpers.go 63.49% <26.31%> (-5.41%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhurley dhurley removed dependencies chore Pull requests for routine tasks labels Aug 14, 2023
@dhurley dhurley merged commit 31290e1 into main Aug 15, 2023
28 checks passed
@dhurley dhurley deleted the fix-nginx-plus-metrics-collection branch August 15, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants