Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ADM resource name dimensions #435

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

p-borole
Copy link
Contributor

@p-borole p-borole commented Aug 14, 2023

Proposed changes

Enhanced advanced metrics to accept new ADM resource name dimensions.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • [✔️] I have read the CONTRIBUTING document
  • [✔️] I have run make install-tools and have attached any dependency changes to this pull request
  • [✔️] If applicable, I have added tests that prove my fix is effective or that my feature works
  • [✔️] If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 28869a0
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/64db38a1931d88000840dcf7

@github-actions github-actions bot added chore Pull requests for routine tasks enhancement New feature or request labels Aug 14, 2023
@oliveromahony
Copy link
Contributor

can you run make install-tools and make deps and commit the changes please?

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02% ⚠️

Comparison is base (25311de) 67.34% compared to head (28869a0) 67.33%.
Report is 1 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
- Coverage   67.34%   67.33%   -0.02%     
==========================================
  Files         113      113              
  Lines       12787    12793       +6     
==========================================
+ Hits         8612     8614       +2     
- Misses       3604     3609       +5     
+ Partials      571      570       -1     
Files Changed Coverage Δ
.../nginx/agent/v2/src/extensions/advanced_metrics.go 82.03% <100.00%> (+0.53%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sanathkumarbs sanathkumarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From an Analytics perspective, LGTM.

I would wait for Agent team members' reviews for feedback on implementation.

@dhurley dhurley removed enhancement New feature or request dependencies labels Aug 15, 2023
@oliveromahony oliveromahony merged commit 3b83243 into nginx:main Aug 15, 2023
28 checks passed
@p-borole p-borole deleted the AddADMResourceNameDims branch August 15, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants