Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition reloading #437

Merged
merged 16 commits into from
Aug 17, 2023
Merged

Race condition reloading #437

merged 16 commits into from
Aug 17, 2023

Conversation

oliveromahony
Copy link
Contributor

@oliveromahony oliveromahony commented Aug 15, 2023

Proposed changes

Reload status url based on reload so that it doesn't cause a race condition.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 78c83b2
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/64de3e5c9667c70008a56853

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies labels Aug 15, 2023
src/core/nginx.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

Patch coverage: 16.66% and project coverage change: +0.15% 🎉

Comparison is base (81b8d9d) 67.04% compared to head (ba2198b) 67.19%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #437      +/-   ##
==========================================
+ Coverage   67.04%   67.19%   +0.15%     
==========================================
  Files         113      113              
  Lines       12844    12848       +4     
==========================================
+ Hits         8611     8633      +22     
+ Misses       3664     3648      -16     
+ Partials      569      567       -2     
Files Changed Coverage Δ
...com/nginx/agent/v2/src/plugins/dataplane_status.go 67.75% <0.00%> (+2.27%) ⬆️
src/core/nginx.go 44.98% <4.00%> (-0.88%) ⬇️
...r/github.com/nginx/agent/v2/src/plugins/metrics.go 70.41% <100.00%> (-0.13%) ⬇️
...dor/github.com/nginx/agent/v2/src/plugins/nginx.go 71.64% <100.00%> (+0.14%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/plugins/dataplane_status.go Outdated Show resolved Hide resolved
src/core/nginx.go Outdated Show resolved Hide resolved
@oliveromahony oliveromahony merged commit 7c1ada3 into main Aug 17, 2023
28 checks passed
@oliveromahony oliveromahony deleted the race-condition-reloading branch August 17, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants