Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make deps and remove duplicate if statement #440

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Conversation

oliveromahony
Copy link
Contributor

Proposed changes

Remove duplicate if, make deps seems to have not been run on main

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Aug 17, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 13e6e10
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/64ddf698d2299a00083d3070

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies labels Aug 17, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.13% 🎉

Comparison is base (0f28539) 67.05% compared to head (e92f967) 67.18%.
Report is 1 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
+ Coverage   67.05%   67.18%   +0.13%     
==========================================
  Files         113      113              
  Lines       12849    12840       -9     
==========================================
+ Hits         8616     8627      +11     
+ Misses       3663     3646      -17     
+ Partials      570      567       -3     
Files Changed Coverage Δ
...dor/github.com/nginx/agent/v2/src/plugins/nginx.go 72.00% <ø> (+0.59%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oliveromahony oliveromahony changed the title amke deps and remove duplicate if statement make deps and remove duplicate if statement Aug 17, 2023
@oliveromahony oliveromahony merged commit b438f24 into main Aug 17, 2023
28 checks passed
@oliveromahony oliveromahony deleted the remove-duplicate-if branch August 17, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants