Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric sender feature #453

Merged
merged 25 commits into from
Aug 28, 2023
Merged

Add metric sender feature #453

merged 25 commits into from
Aug 28, 2023

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

  • Add metric-sender feature so it is now possible to enable/disable as desired
  • Add metric-collection feature
  • Add metric feature which includes metrics-collection, metrics-throttle and metrics-sender features
  • Improve metric plugin can so it can now stream metric reports directly to metric-sender
  • Linting

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@Dean-Coakley Dean-Coakley self-assigned this Aug 25, 2023
@netlify
Copy link

netlify bot commented Aug 25, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 1625b76
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/64ec6de216c9c800082de0c8

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies enhancement New feature or request labels Aug 25, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 25.53% and project coverage change: -0.39% ⚠️

Comparison is base (7c1ada3) 67.19% compared to head (b0ea6a7) 66.81%.
Report is 1 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #453      +/-   ##
==========================================
- Coverage   67.19%   66.81%   -0.39%     
==========================================
  Files         113      113              
  Lines       12849    12912      +63     
==========================================
- Hits         8634     8627       -7     
- Misses       3647     3717      +70     
  Partials      568      568              
Files Changed Coverage Δ
...b.com/nginx/agent/v2/src/plugins/metrics_sender.go 59.42% <0.00%> (ø)
.../nginx/agent/sdk/v2/agent/config/config_helpers.go 28.20% <ø> (-1.07%) ⬇️
...or/github.com/nginx/agent/sdk/v2/config_helpers.go 64.00% <0.00%> (ø)
...r/github.com/nginx/agent/v2/src/plugins/metrics.go 66.92% <11.11%> (-3.49%) ⬇️
.../github.com/nginx/agent/v2/src/plugins/features.go 35.02% <28.57%> (-1.54%) ⬇️
...om/nginx/agent/v2/src/plugins/metrics_throlling.go 58.46% <50.00%> (ø)
...ginx/agent/v2/src/core/metrics/collectors/nginx.go 87.35% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/plugins/features.go Outdated Show resolved Hide resolved
src/core/topics.go Outdated Show resolved Hide resolved
@oliveromahony
Copy link
Contributor

Tested and LGTM

@Dean-Coakley Dean-Coakley merged commit 5329b27 into main Aug 28, 2023
28 checks passed
@Dean-Coakley Dean-Coakley deleted the add-feat-metric-sender branch August 28, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants