Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add worker conn metrics #461

Merged
merged 14 commits into from
Sep 13, 2023
Merged

Add worker conn metrics #461

merged 14 commits into from
Sep 13, 2023

Conversation

Dean-Coakley
Copy link
Contributor

@Dean-Coakley Dean-Coakley commented Aug 31, 2023

Proposed changes

  • Add worker metrics from R30 release
  • Change: detect latest api version and use that rather than defaulting to 6.
    • Now falls back to version 7 if apiVersion can not be determined
  • Improve nginx plus collector tests. Reduced footprint and increase coverage

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Aug 31, 2023

Deploy Preview for agent-public-docs ready!

Name Link
🔨 Latest commit dabeaff
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/6500904258f619000825e7c7
😎 Deploy Preview https://deploy-preview-461--agent-public-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies labels Aug 31, 2023
@Dean-Coakley Dean-Coakley self-assigned this Aug 31, 2023
@Dean-Coakley Dean-Coakley changed the title [WIP] Add worker conn metrics Add worker conn metrics Aug 31, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2023

Codecov Report

Patch coverage: 74.11% and project coverage change: +0.06% 🎉

Comparison is base (a9728fe) 66.19% compared to head (dabeaff) 66.26%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #461      +/-   ##
==========================================
+ Coverage   66.19%   66.26%   +0.06%     
==========================================
  Files         118      118              
  Lines       13313    13390      +77     
==========================================
+ Hits         8813     8873      +60     
- Misses       3916     3927      +11     
- Partials      584      590       +6     
Files Changed Coverage Δ
src/core/config/defaults.go 0.00% <ø> (ø)
...nx/agent/v2/src/core/metrics/sources/nginx_plus.go 70.57% <72.15%> (+0.39%) ⬆️
...om/nginx/agent/v2/src/core/metrics/metrics_util.go 83.04% <100.00%> (+0.29%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oliveromahony oliveromahony merged commit 556f51e into main Sep 13, 2023
29 checks passed
@oliveromahony oliveromahony deleted the add-worker-conn-metrics branch September 13, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants