Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for file actions during a config apply #464

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

dhurley
Copy link
Collaborator

@dhurley dhurley commented Sep 4, 2023

Proposed changes

With the addition of file actions, we can now support partial updates to NGINX configuration. Before all NGINX config files needed to be sent to perform a config apply. Now you only need to send the files that you have made updates to.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Sep 4, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit e3df68a
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/64f859f92a2a4e0008037fad

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies labels Sep 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2023

Codecov Report

Patch coverage: 51.44% and project coverage change: -0.32% ⚠️

Comparison is base (131ae14) 67.05% compared to head (e3df68a) 66.74%.
Report is 1 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
- Coverage   67.05%   66.74%   -0.32%     
==========================================
  Files         113      113              
  Lines       12931    13020      +89     
==========================================
+ Hits         8671     8690      +19     
- Misses       3687     3754      +67     
- Partials      573      576       +3     
Files Changed Coverage Δ
src/core/nginx.go 44.33% <49.47%> (-0.29%) ⬇️
src/core/environment.go 52.36% <55.81%> (+0.33%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/core/nginx.go Show resolved Hide resolved
src/core/nginx.go Outdated Show resolved Hide resolved
src/core/nginx.go Show resolved Hide resolved
src/core/nginx.go Show resolved Hide resolved
src/core/nginx.go Outdated Show resolved Hide resolved
@dhurley dhurley merged commit a668cb1 into main Sep 11, 2023
29 checks passed
@dhurley dhurley deleted the add-file-actions-support branch September 11, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants