Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure fullpath #471

Merged
merged 1 commit into from
Sep 12, 2023
Merged

fix: ensure fullpath #471

merged 1 commit into from
Sep 12, 2023

Conversation

nginx-nickc
Copy link
Contributor

Proposed changes

  • ensures full path when doing file operation using directory map, this is consistent with previous assumptions

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Sep 11, 2023 •
edited

✅ Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 9a7b722
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/64ff867bad258800083d3928

@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks dependencies labels Sep 11, 2023
@oliveromahony oliveromahony merged commit 9a61fc7 into nginx:main Sep 12, 2023
29 checks passed
oliveromahony added a commit that referenced this pull request Sep 12, 2023
@oliveromahony
Revert "fix: ensure fullpath (#471)"
625b7f0 
This reverts commit 9a61fc7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliveromahony oliveromahony oliveromahony approved these changes

@dhurley dhurley dhurley approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@aphralG aphralG aphralG approved these changes

@craigell craigell Awaiting requested review from craigell

Assignees
No one assigned
Labels
bug Something isn't working chore Pull requests for routine tasks dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nginx-nickc @oliveromahony @dhurley @Dean-Coakley @aphralG @nickchen