Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grpc integration tests #475

Merged
merged 8 commits into from
Sep 21, 2023
Merged

Add grpc integration tests #475

merged 8 commits into from
Sep 21, 2023

Conversation

dhurley
Copy link
Collaborator

@dhurley dhurley commented Sep 14, 2023

Proposed changes

Add grpc integration tests

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Sep 14, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 266d858
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/650c4b4a3c437300087680cc

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies labels Sep 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023

Codecov Report

Patch coverage: 89.47% and project coverage change: -0.20% ⚠️

Comparison is base (dbfd11e) 66.40% compared to head (672bcf6) 66.21%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #475      +/-   ##
==========================================
- Coverage   66.40%   66.21%   -0.20%     
==========================================
  Files         118      118              
  Lines       13398    13384      -14     
==========================================
- Hits         8897     8862      -35     
- Misses       3911     3932      +21     
  Partials      590      590              
Files Changed Coverage Δ
...dor/github.com/nginx/agent/v2/src/plugins/nginx.go 71.63% <50.00%> (-0.57%) ⬇️
.../github.com/nginx/agent/v2/src/plugins/features.go 37.00% <87.50%> (+0.27%) ⬆️
...or/github.com/nginx/agent/v2/src/plugins/common.go 70.23% <100.00%> (ø)
...or/github.com/nginx/agent/v2/src/plugins/events.go 84.17% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhurley dhurley merged commit d75b51e into main Sep 21, 2023
28 checks passed
@dhurley dhurley deleted the add-grpc-integration-tests branch September 21, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants