Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests #478

Merged
merged 10 commits into from
Sep 20, 2023
Merged

Fix integration tests #478

merged 10 commits into from
Sep 20, 2023

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Sep 18, 2023

Proposed changes

Fix failing integration tests

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this Sep 18, 2023
@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 58e7eb5
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/650ab6b621ea2500086f93d0

@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks dependencies labels Sep 18, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 88.88% and project coverage change: -0.16% ⚠️

Comparison is base (556f51e) 66.44% compared to head (603ca88) 66.29%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
- Coverage   66.44%   66.29%   -0.16%     
==========================================
  Files         118      118              
  Lines       13390    13391       +1     
==========================================
- Hits         8897     8877      -20     
- Misses       3903     3924      +21     
  Partials      590      590              
Files Changed Coverage Δ
src/core/pipe.go 54.09% <50.00%> (ø)
...dor/github.com/nginx/agent/v2/src/plugins/nginx.go 72.19% <100.00%> (+0.04%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

main.go Show resolved Hide resolved
@aphralG aphralG merged commit 4747879 into main Sep 20, 2023
28 checks passed
@aphralG aphralG deleted the fix-integration-tests branch September 20, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore Pull requests for routine tasks dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants