Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional check to nginxProcesses #483

Merged
merged 23 commits into from
Oct 3, 2023
Merged

add additional check to nginxProcesses #483

merged 23 commits into from
Oct 3, 2023

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Sep 22, 2023

Proposed changes

Add additional check to nginxProcesses to check process cmd has prefix of nginx:

Move if statement used to check processes to a separate function to add unit tests

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Sep 22, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit d77226b
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/651c1a75fe2460000873a431

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies labels Sep 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ab97ac9) 66.23% compared to head (d77226b) 66.29%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #483      +/-   ##
==========================================
+ Coverage   66.23%   66.29%   +0.06%     
==========================================
  Files         118      118              
  Lines       13441    13443       +2     
==========================================
+ Hits         8902     8912      +10     
+ Misses       3944     3938       -6     
+ Partials      595      593       -2     
Files Coverage Δ
src/core/environment.go 51.16% <66.66%> (+0.14%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/core/environment.go Outdated Show resolved Hide resolved
src/core/environment.go Outdated Show resolved Hide resolved
Co-authored-by: Donal Hurley <djhurley1990@gmail.com>
@aphralG aphralG merged commit 70ffa9d into main Oct 3, 2023
28 checks passed
@aphralG aphralG deleted the nginx-processes-check branch October 3, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants