Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NGINX plugin to read NGINX config on startup #489

Merged
merged 4 commits into from
Oct 4, 2023

Conversation

dhurley
Copy link
Collaborator

@dhurley dhurley commented Sep 28, 2023

Proposed changes

  • Update nginx-agent.conf for grafana example
  • Update NGINX plugin to read NGINX config on startup to get access/error log information
  • Add fix do that Agent start and NGINX found events get sent

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 9fd690c
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/651d3751e118d100077da909

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation labels Sep 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (df8cf6e) 66.29% compared to head (0def6fc) 66.28%.
Report is 4 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
- Coverage   66.29%   66.28%   -0.01%     
==========================================
  Files         118      118              
  Lines       13441    13446       +5     
==========================================
+ Hits         8911     8913       +2     
- Misses       3936     3938       +2     
- Partials      594      595       +1     
Files Coverage Δ
src/core/pipe.go 54.09% <50.00%> (ø)
...dor/github.com/nginx/agent/v2/src/plugins/nginx.go 71.15% <75.00%> (-0.28%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhurley dhurley changed the title Update nginx-agent.conf for grafana example Update NGINX plugin to read NGINX config on startup Oct 4, 2023
@dhurley dhurley merged commit a94d816 into main Oct 4, 2023
28 checks passed
@dhurley dhurley deleted the fix-grafana-example branch October 4, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants