Update fonts #111
Merged
Update fonts #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nginx-unit ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
LGTM once the new woff2's are committed, thank you! Your commit message is missing its closing In the future, it could be neat to ship a single variable font of Open Sans, but not worth the effort for the moment. |
|
Actually add the fonts |
|
Tweak commit message |
|
I'm not actually seeing the fonts in the deploy preview; the woff2's are 404'ing it's falling back to Arial. |
callahad
requested changes
Feb 27, 2024
|
Expand the commit message a little regarding WOFF vs WOFF2 |
|
|
Fix font paths |
|
During build, static files get collected into You can drop the relative bits and use |
|
OK, I'll try that because this is giving me a 404... |
|
Update font paths again... |
|
That's working! Woo! Looking at the diff one more time, I noticed that we were using a helper function for building paths (and appending hashes for cache-busting). If we want to follow precedent: diff --git a/source/theme/layout.html b/source/theme/layout.html
index 3bd369a..27d2797 100644
--- a/source/theme/layout.html
+++ b/source/theme/layout.html
@@ -37,7 +37,7 @@
font-style: normal;
font-weight: 400;
src: local('OpenSans'), local('Open Sans'), local('Open Sans Regular'), local('OpenSans-Regular'),
- url('/_static/open-sans-v40-latin_latin-ext-regular.woff2') format('woff2');
+ url('{{ pathto('/_static/open-sans-v40-latin_latin-ext-regular.woff2', 1) + '?' + md5('theme/static/open-sans-v40-latin_latin-ext-regular.woff2') }}') format('woff2');
}
/* open-sans-italic - latin_latin-ext */
@@ -47,7 +47,7 @@
font-style: italic;
font-weight: 400;
src: local('OpenSansItalic'), local('Open Sans Italic'), local('OpenSans Italic'), local('OpenSans-Italic'),
- url('/_static/open-sans-v40-latin_latin-ext-italic.woff2') format('woff2');
+ url('{{ pathto('/_static/open-sans-v40-latin_latin-ext-italic.woff2', 1) + '?' + md5('theme/static/open-sans-v40-latin_latin-ext-italic.woff2') }}') format('woff2');
}
/* open-sans-700 - latin_latin-ext */
@@ -57,7 +57,7 @@
font-style: normal;
font-weight: 700;
src: local('OpenSansBold'), local('Open Sans Bold'), local('OpenSans Bold'), local('OpenSans-Bold'),
- url('/_static/open-sans-v40-latin_latin-ext-700.woff2') format('woff2');
+ url('{{ pathto('/_static/open-sans-v40-latin_latin-ext-700.woff2', 1) + '?' + md5('theme/static/open-sans-v40-latin_latin-ext-700.woff2') }}') format('woff2');
}
/* open-sans-700italic - latin_latin-ext */
@@ -67,7 +67,7 @@
font-style: italic;
font-weight: 700;
src: local('OpenSansBoldItalic'), local('Open Sans Bold Italic'), local('OpenSans Bold Italic'), local('OpenSans-BoldItalic'), local('OpenSans-Bold-Italic'),
- url('/_static/open-sans-v40-latin_latin-ext-700italic.woff2') format('woff2');
+ url('{{ pathto('/_static/open-sans-v40-latin_latin-ext-700italic.woff2', 1) + '?' + md5('theme/static/open-sans-v40-latin_latin-ext-700italic.woff2') }}') format('woff2');
}
</style> |
|
I'll see if it still works with your change... |
|
Yeah it works... |
|
Use the css pathto magic + md5 sum as before |
|
Check out this sweet before/after. We have bold! 
|
callahad
approved these changes
Feb 27, 2024
Update the bundled Open Sans fonts using <https://gwfh.mranftl.com/fonts/open-sans?subsets=latin,latin-ext> These include Regular and Italic and Bold (700) and Bold (700) Italic for the latin and latin extended character sets. This removes the older WOFF format font and we now only use WOFF2 fonts. WOFF2 offers better compression amongst other things. It is supported by all modern browsers... Edge (since version 14) Google Chrome (since version 36) Firefox (since version 35) Opera (since version 26) Safari (since version 10) Closes: nginx#109 Reviewed-by: Dan Callahan <d.callahan@f5.com> Signed-off-by: Andrew Clayton <a.clayton@nginx.com>
|
Add Dan's Reviewed-by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the bundled Open Sans fonts from
https://gwfh.mranftl.com/fonts/open-sans?subsets=latin,latin-ext
These includes Regular and Italic and Bold (700) and Bold (700) Italic for the latin and latin extended character sets.