Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Molecule: Installation of NGINX Plus failing on all configured distributions #115

Closed
fschueller opened this issue Apr 28, 2021 · 1 comment
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@fschueller
Copy link
Contributor

Describe the bug

While running the molecule tests, the installation of NGINX Plus is failing.

Screenshot 2021-04-28 at 09 46 29

To reproduce

Steps to reproduce the behavior:

  1. Checkout the repository on main
  2. Run molecule test --all
  3. See above error.

Expected behavior

All tests passing

Your environment:

  • NGINX Config Role on main, commit 797232e0dbef01c0ce21ea3bd5ba48d26094df5e
  • ansible 2.10.8
  • molecule 3.3.0 using python 3.9
  • MacOS 11.2.3

Additional context

I found this while testing my contribution. As it is happening on main too, I don't see this related to my changes. If you think this is an edge case related to my own setup, please don't feel compelled to process this.

@alessfg
Copy link
Collaborator

alessfg commented Apr 28, 2021

Ah right, the NGINX Plus test requires you to have an NGINX Plus license (trial licenses should be fine). The fact that you are the first person to catch this makes me wonder how many people actually run tests locally before submitting a PR 😅

That being said, I do not expect nor want people to go through the trial license process unless you are specifically working on something unique to NGINX Plus. I'll update the contribution guidelines to make a note about it.

alessfg added a commit that referenced this issue Apr 29, 2021
alessfg added a commit that referenced this issue Apr 29, 2021
@alessfg alessfg added the documentation Improvements or additions to documentation label Apr 29, 2021
@alessfg alessfg added this to To do in Documentation via automation Apr 29, 2021
@alessfg alessfg added this to the 0.4.0 milestone Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
No open projects
Documentation
  
To do
Development

No branches or pull requests

2 participants