Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated parameters #202

Merged
merged 2 commits into from Dec 11, 2021
Merged

Remove deprecated parameters #202

merged 2 commits into from Dec 11, 2021

Conversation

alessfg
Copy link
Collaborator

@alessfg alessfg commented Dec 11, 2021 •
edited

Proposed changes

Remove parameters deprecated in release 0.4.0. To recap, these are nginx_config_main_upload_*, nginx_config_upload_html_*, and nginx_config_stream_upload_*. Use nginx_config_upload instead.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

@alessfg alessfg self-assigned this Dec 11, 2021
@alessfg alessfg added the breaking change Implies a breaking change label Dec 11, 2021
@alessfg alessfg added this to In progress in NGINX Configuration via automation Dec 11, 2021
@alessfg alessfg added this to the 0.4.3 milestone Dec 11, 2021
@github-actions github-actions bot added the deprecation Functionality is deprecated label Dec 11, 2021
@alessfg alessfg merged commit bc47f38 into main Dec 11, 2021
NGINX Configuration automation moved this from In progress to Done Dec 11, 2021
@alessfg alessfg deleted the remove-deprecated-options branch December 11, 2021 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknot242 aknot242 aknot242 approved these changes

Assignees

@alessfg alessfg

Labels
breaking change Implies a breaking change deprecation Functionality is deprecated
Projects
NGINX Configuration
  
Done
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alessfg @aknot242