Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the URL used to fetch the latest NGINX source version #411

Merged
merged 2 commits into from
May 26, 2021
Merged

Update the URL used to fetch the latest NGINX source version #411

merged 2 commits into from
May 26, 2021

Conversation

alessfg
Copy link
Collaborator

@alessfg alessfg commented May 26, 2021 •
edited

Proposed changes

Change the url used to grep the latest NGINX version when installing from source. This should avoid the source install failing whenever the stable release is higher than the latest mainline.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

@alessfg alessfg self-assigned this May 26, 2021
@alessfg alessfg added the bug Something isn't working label May 26, 2021
@alessfg alessfg added this to the 0.20.0 milestone May 26, 2021
@alessfg alessfg changed the title Update the URL used to fetch the latest NGINX version when installing from source Update the URL used to fetch the latest NGINX source version May 26, 2021
@alessfg alessfg merged commit d3cfac4 into main May 26, 2021
@alessfg alessfg deleted the fix-source-install-once-and-for-all branch May 26, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alessfg alessfg

Labels
bug Something isn't working
Projects
NGINX Ansible roles & collection
Status: Done
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@alessfg