Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace "yes"/"no" boolean values with "true"/"false" #414

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Replace "yes"/"no" boolean values with "true"/"false" #414

merged 1 commit into from
Jun 2, 2021

Conversation

alessfg
Copy link
Collaborator

@alessfg alessfg commented Jun 2, 2021 •
edited

Proposed changes

Replace "yes"/"no" boolean values with "true"/"false" to comply with YAML spec 1.2.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

@alessfg alessfg self-assigned this Jun 2, 2021
@alessfg alessfg added the enhancement Enhance/improve an existing feature label Jun 2, 2021
@alessfg alessfg added this to the 0.20.0 milestone Jun 2, 2021
@alessfg alessfg merged commit fb391a0 into main Jun 2, 2021
@alessfg alessfg deleted the replace-boolean-values-by-truthy-values branch June 2, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alessfg alessfg

Labels
enhancement Enhance/improve an existing feature
Projects
NGINX Ansible roles & collection
Status: Done
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@alessfg