Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve workflow for building NGINX from source #573

Merged
merged 4 commits into from Jan 15, 2023

Conversation

alessfg
Copy link
Collaborator

@alessfg alessfg commented Jan 15, 2023

Proposed changes

BREAKING CHANGES:

  • When building from source the various libraries required to build NGINX from source, you will no longer need to specify the name of the package, only the version:

    pcre_version: pcre2-10.42

    is now:

    pcre_version: 10.42
  • The nginx_install_source_<package>: false parameters have been reversed. Setting nginx_install_source_pcre: true will now build PCRE from source, instead of using the default package manager. The previous behavior was unintuitive at best.

ENHANCEMENTS:

Use the official GitHub repositories as the source for the various packages required to compile NGINX OSS from source.

BUG FIXES:

Update the versions of the various packages required to build NGINX from source. The version of zlib listed in the role was no longer available. (Fixes #555.)

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

@github-actions github-actions bot added the breaking change Implies a breaking change label Jan 15, 2023
@alessfg alessfg self-assigned this Jan 15, 2023
@alessfg alessfg added bug Something isn't working enhancement Enhance/improve an existing feature labels Jan 15, 2023
@alessfg alessfg added this to the 0.23.3 milestone Jan 15, 2023
@alessfg alessfg merged commit 03ed41e into main Jan 15, 2023
@alessfg alessfg deleted the source-install-improvements branch January 15, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Implies a breaking change bug Something isn't working enhancement Enhance/improve an existing feature
Development

Successfully merging this pull request may close these issues.

Bug nginx_install_from: source (update zlib_version)
1 participant