Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check distribution and validate role variables #583

Merged
merged 15 commits into from Jan 29, 2023
Merged

Check distribution and validate role variables #583

merged 15 commits into from Jan 29, 2023

Conversation

alessfg
Copy link
Collaborator

@alessfg alessfg commented Jan 29, 2023 •
edited

Proposed changes

FEATURES:

Validate that various role variables have been set to one of the allowed values.

ENHANCEMENTS:

Improve validation of supported distributions when installing NGINX from the official repository.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

@alessfg alessfg self-assigned this Jan 29, 2023
@alessfg alessfg added the feature New feature or request label Jan 29, 2023
@alessfg alessfg added this to the 0.23.3 milestone Jan 29, 2023
@github-actions github-actions bot added the tests Improvements to tests label Jan 29, 2023
@alessfg alessfg removed the tests Improvements to tests label Jan 29, 2023
@alessfg alessfg changed the title Add distribution Molecule scenario Validate distribution and role variables Jan 29, 2023
@alessfg alessfg changed the title Validate distribution and role variables Check distribution and validate role variables Jan 29, 2023
@alessfg alessfg added the enhancement Enhance/improve an existing feature label Jan 29, 2023
@alessfg alessfg merged commit 1ba553b into main Jan 29, 2023
@alessfg alessfg deleted the validate branch January 29, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alessfg alessfg

Labels
enhancement Enhance/improve an existing feature feature New feature or request
Projects
NGINX Ansible roles & collection
Status: Done
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@alessfg