Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize code from dot to array notation #584

Merged
merged 18 commits into from Jan 29, 2023
Merged

Standardize code from dot to array notation #584

merged 18 commits into from Jan 29, 2023

Conversation

alessfg
Copy link
Collaborator

@alessfg alessfg commented Jan 29, 2023

Proposed changes

  • Standardize code from dot to array notation to keep in with the standards set by the other roles in the Ansible NGINX core collection.
  • Bump the minimum version of Ansible core required to run the role to 2.12 (2.11 is no longer supported by Ansible).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

@alessfg alessfg self-assigned this Jan 29, 2023
@alessfg alessfg added the enhancement Enhance/improve an existing feature label Jan 29, 2023
@alessfg alessfg added this to the 0.23.3 milestone Jan 29, 2023
@alessfg alessfg merged commit 058cb57 into main Jan 29, 2023
@alessfg alessfg deleted the cleanup-code branch January 29, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhance/improve an existing feature
Development

Successfully merging this pull request may close these issues.

None yet

1 participant