Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type annotations for crossplane #112

Open
pyhedgehog opened this issue May 20, 2024 · 0 comments · May be fixed by #113
Open

Type annotations for crossplane #112

pyhedgehog opened this issue May 20, 2024 · 0 comments · May be fixed by #113

Comments

@pyhedgehog
Copy link

Is your feature request related to a problem? Please describe.
In almost all new code I use mypy as one of pre-commit checks. This implies that I want type annotations for all libraries used.

Describe the solution you'd like
I have a PR with type annotations. I even made special efforts to be compatible with Python 3.7 and have no runtime dependency on typing_extensions module. But this solution still incompatible with Python 2.

Describe alternatives you've considered
Alternative is to separate type annotations and make PR to typeshed. Please let me know if you prefer this option, whether you will do this PR yourself or if you want me to do it.

@pyhedgehog pyhedgehog linked a pull request May 20, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant