Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename read_crds to read_custom_resource #1519

Merged
merged 1 commit into from Apr 8, 2021
Merged

Rename read_crds to read_custom_resource #1519

merged 1 commit into from Apr 8, 2021

Conversation

soneillf5
Copy link
Contributor

@soneillf5 soneillf5 commented Apr 7, 2021 •
edited

Proposed changes

read_crds actually reads any custom resource. This is just a name change to reflect this.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@soneillf5 soneillf5 merged commit c2d5371 into master Apr 8, 2021
@soneillf5 soneillf5 deleted the feature-rename-read-crd branch April 8, 2021 09:05
lucacome pushed a commit that referenced this pull request Apr 19, 2021
@soneillf5 @lucacome
Rename read_crds to read_custom_resource (#1519)
392a132
@lucacome lucacome added the chore Pull requests for routine tasks label Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

@vepatel vepatel vepatel approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@soneillf5 @ciarams87 @vepatel @lucacome