Cancel redundant pipelines and remove redundant build jobs #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarams87
force-pushed
the
chore/cancel-redundant-pipelines
branch
from
19e2819
to
a821356
Compare
soneillf5
approved these changes
Apr 9, 2021
ciarams87
force-pushed
the
chore/cancel-redundant-pipelines
branch
from
a821356
to
d3b7190
Compare
ciarams87
force-pushed
the
chore/cancel-redundant-pipelines
branch
from
d3b7190
to
1032b36
Compare
ciarams87
changed the title
vepatel
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This commit creates a 'cancel' action which will cancel any redundant pipelines running for a PR or for master (i.e. after pushing a new commit). It also removes the 'build' step from the edge and nightly pipelines as it is unnecessary - we have to build again for the smoke tests and for the release step anyway.
-> see https://github.com/nginxinc/kubernetes-ingress/runs/2305289060?check_suite_focus=true to see it in action
Checklist
Before creating a PR, run through this checklist and mark each as complete.