Add tests for Ingress TLS termination #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vepatel
reviewed
Apr 12, 2021
tests/suite/test_tls.py
Outdated
| try: | ||
| get_server_certificate_subject(endpoint.public_ip, host, endpoint.port_ssl) | ||
| pytest.fail("We expected an SSLError here, but didn't get it or got another error. Exiting...") | ||
| except SSLError: |
There was a problem hiding this comment.
@pleshakov can we assert something negative rather than failing the test?
soneillf5
approved these changes
Apr 12, 2021
When NGINX terminates a TLS connection for a server with a missing/invalid TLS secret, we expect NGINX to reject the connection with the error TLSV1_UNRECOGNIZED_NAME In this commit we: * ensure the specific error * rename the assertion function to be more specific
lucacome
approved these changes
Apr 12, 2021
vepatel
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add tests for Ingress TLS termination
The new tests follow https://github.com/nginxinc/kubernetes-ingress/blob/master/tests/suite/test_virtual_server_tls.py
Happy to hear thoughts about combining both Ingress and TLS into one.