Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests Dockerfile #1536

Merged
merged 1 commit into from Apr 14, 2021
Merged

Improve tests Dockerfile #1536

merged 1 commit into from Apr 14, 2021

Conversation

pleshakov
Copy link
Contributor

Proposed changes

  • Reorganize layers so that changes to the tests do not cause a full image rebuilt
  • Use .dockerignore to ignore cache folders
  • Convert spaces to tabs for consistency with the other Dockerfiles

@pleshakov
Improve tests Dockerfile
3afcd8f 
* Reorganize layers so that changes to the tests do not cause a full
image rebuilt
* Use .dockerignore to ignore cache folders
* Convert spaces to tabs for consistency with the other Dockerfiles
@pleshakov pleshakov added the python Pull requests that update Python code label Apr 13, 2021
@pleshakov pleshakov merged commit 4cae197 into master Apr 14, 2021
@pleshakov pleshakov deleted the improve-test-dockerfile branch April 14, 2021 16:29
@lucacome lucacome added the chore Pull requests for routine tasks label Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

@vepatel vepatel vepatel approved these changes

@lucacome lucacome Awaiting requested review from lucacome

@soneillf5 soneillf5 Awaiting requested review from soneillf5

Assignees
No one assigned
Labels
chore Pull requests for routine tasks python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pleshakov @ciarams87 @vepatel @lucacome