Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for TransportServer load balancing config #1543

Merged
merged 1 commit into from Apr 27, 2021

Conversation

soneillf5
Copy link
Contributor

@soneillf5 soneillf5 commented Apr 19, 2021

Proposed changes

Adds a basic check for the config change relating to the number of replicas updating the stream/tcp load balancing config on the nginx instance.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@soneillf5 soneillf5 requested a review from vepatel April 19, 2021 11:26
@soneillf5 soneillf5 force-pushed the feature-transportserver-tcp-tests branch 2 times, most recently from 43d03d5 to 61410b4 Compare April 19, 2021 11:29
tests/suite/fixtures.py Outdated Show resolved Hide resolved
tests/tcp-server/main.go Show resolved Hide resolved
tests/suite/test_transport_server_tcp_load_balance.py Outdated Show resolved Hide resolved
tests/suite/resources_utils.py Outdated Show resolved Hide resolved
tests/suite/test_transport_server_tcp_load_balance.py Outdated Show resolved Hide resolved
tests/suite/resources_utils.py Outdated Show resolved Hide resolved
tests/suite/test_transport_server_tcp_load_balance.py Outdated Show resolved Hide resolved
@soneillf5 soneillf5 force-pushed the feature-transportserver-tcp-tests branch 2 times, most recently from 0674385 to 9b4edcc Compare April 22, 2021 16:00
@soneillf5 soneillf5 force-pushed the feature-transportserver-tcp-tests branch 3 times, most recently from df66dac to c6511cf Compare April 22, 2021 16:14
tests/suite/test_transport_server_tcp_load_balance.py Outdated Show resolved Hide resolved
tests/suite/fixtures.py Outdated Show resolved Hide resolved
tests/tcp-server/main.go Outdated Show resolved Hide resolved
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked well in kind!

suite/test_transport_server_tcp_load_balance.py::TestTransportServerTcpLoadBalance::test_number_of_replicas[crd_ingress_controller0-transport_server_setup0] PASSED [ 50%]
suite/test_transport_server_tcp_load_balance.py::TestTransportServerTcpLoadBalance::test_tcp_request_load_balanced[crd_ingress_controller0-transport_server_setup0] PASSED [100%]

IC logs:

10.244.0.1 [23/Apr/2021:16:26:14 +0000] TCP 200 16 0 0.003 "-"
10.244.0.1 [23/Apr/2021:16:26:14 +0000] TCP 200 16 0 0.004 "-"
10.244.0.1 [23/Apr/2021:16:26:14 +0000] TCP 200 16 0 0.044 "-"
10.244.0.1 [23/Apr/2021:16:26:14 +0000] TCP 200 16 0 0.022 "-"
10.244.0.1 [23/Apr/2021:16:26:14 +0000] TCP 200 16 0 0.020 "-"
10.244.0.1 [23/Apr/2021:16:26:14 +0000] TCP 200 16 0 0.001 "-"
10.244.0.1 [23/Apr/2021:16:26:14 +0000] TCP 200 16 0 0.022 "-"
10.244.0.1 [23/Apr/2021:16:26:14 +0000] TCP 200 16 0 0.032 "-"
10.244.0.1 [23/Apr/2021:16:26:14 +0000] TCP 200 16 0 0.013 "-"
10.244.0.1 [23/Apr/2021:16:26:14 +0000] TCP 200 16 0 0.004 "-"
10.244.0.1 [23/Apr/2021:16:26:14 +0000] TCP 200 16 0 0.007 "-"
10.244.0.1 [23/Apr/2021:16:26:14 +0000] TCP 200 16 0 0.002 "-"
10.244.0.1 [23/Apr/2021:16:26:14 +0000] TCP 200 16 0 0.002 "-"
10.244.0.1 [23/Apr/2021:16:26:14 +0000] TCP 200 16 0 0.001 "-"
10.244.0.1 [23/Apr/2021:16:26:14 +0000] TCP 200 16 0 0.004 "-"
10.244.0.1 [23/Apr/2021:16:26:14 +0000] TCP 200 16 0 0.008 "-"
10.244.0.1 [23/Apr/2021:16:26:14 +0000] TCP 200 16 0 0.002 "-"
10.244.0.1 [23/Apr/2021:16:26:14 +0000] TCP 200 16 0 0.004 "-"
10.244.0.1 [23/Apr/2021:16:26:14 +0000] TCP 200 16 0 0.003 "-"
10.244.0.1 [23/Apr/2021:16:26:14 +0000] TCP 200 16 0 0.011 "-"

tests/tcp-server/README.md Outdated Show resolved Hide resolved
tests/suite/resources_utils.py Outdated Show resolved Hide resolved
@soneillf5 soneillf5 force-pushed the feature-transportserver-tcp-tests branch from 919d5ff to e9d3568 Compare April 26, 2021 11:04
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Apr 26, 2021
@soneillf5 soneillf5 requested a review from vepatel April 26, 2021 11:58
@soneillf5 soneillf5 force-pushed the feature-transportserver-tcp-tests branch from 538163f to 50ea1eb Compare April 27, 2021 10:53
@soneillf5 soneillf5 merged commit cbccdce into master Apr 27, 2021
@lucacome lucacome deleted the feature-transportserver-tcp-tests branch April 27, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants