Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ts snippet tests #1568

Merged
merged 2 commits into from May 6, 2021
Merged

add ts snippet tests #1568

merged 2 commits into from May 6, 2021

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented May 4, 2021 •
edited

Proposed changes

  • Add test case for checking snippet entries in ts config.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

soneillf5
soneillf5 approved these changes May 5, 2021
View reviewed changes
tests/suite/test_transport_server_snippets.py Outdated Show resolved Hide resolved
@vepatel vepatel merged commit 8c8b734 into master May 6, 2021
@vepatel vepatel deleted the tests/ts-snippets branch May 6, 2021 10:59
@lucacome lucacome added the chore Pull requests for routine tasks label Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@soneillf5 soneillf5 soneillf5 approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vepatel @pleshakov @soneillf5 @lucacome