Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container scanning for OSS images #1580

Merged
merged 1 commit into from May 12, 2021
Merged

Conversation

ciarams87
Copy link
Member

Proposed changes

Add trivy container scanning for OSS images. Scanning of the Plus and App Protect images will be done separately in GitLab.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have rebased my branch onto master

@github-actions github-actions bot added the chore Pull requests for routine tasks label May 7, 2021
@ciarams87 ciarams87 self-assigned this May 7, 2021
Copy link
Member

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to build the images again? Can't it just be a step in one of the other builds?

.github/workflows/edge.yml Outdated Show resolved Hide resolved
.github/workflows/edge.yml Outdated Show resolved Hide resolved
@ciarams87
Copy link
Member Author

ciarams87 commented May 10, 2021

Do we need to build the images again? Can't it just be a step in one of the other builds?

@lucacome It could just be a step in another build, but having it as a separate stage runs these jobs concurrently with the other helm and smoke tests, so it doesn't take any longer, and I think it's easier to follow this way.

@ciarams87 ciarams87 merged commit 5361e0a into master May 12, 2021
@ciarams87 ciarams87 deleted the chore/container-scanning branch May 12, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants