Improve nap unit tests #1589
Merged
Improve nap unit tests #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soneillf5
approved these changes
May 12, 2021
internal/k8s/handlers.go
Outdated
| @@ -523,6 +523,7 @@ func createAppProtectPolicyHandlers(lbc *LoadBalancerController) cache.ResourceE | |||
| return handlers | |||
| } | |||
|
|
|||
| // compareSpecs returns true if the resources are different. | |||
| func compareSpecs(oldresource, resource *unstructured.Unstructured) (bool, error) { | |||
There was a problem hiding this comment.
Would it help to rename the function "areResourcesDifferent" ?
pleshakov
force-pushed
the
improve-nap-unit-tests
branch
from
345543d
to
e6cd9fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add unit tests/improve existing ones for AppProtect related code