Add smoke test for appprotect csrf policy #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleshakov
approved these changes
May 25, 2021
| print("----------------------- Send request with http origin header ----------------------") | ||
|
|
||
| headers = {"host": backend_setup.ingress_host, "Origin": "http://appprotect.example.com"} | ||
| resp_valid = requests.post(backend_setup.req_url, headers=headers, verify=False, cookies={"flavor": "darkchoco"}) |
There was a problem hiding this comment.
are cookies necessary? the policy doesn't configure any rules for cookies, right?
There was a problem hiding this comment.
@pleshakov cookies are necessary for CSRF protection to kick in
| time.sleep(1) | ||
| pytest.fail(f"Keep getting 502|504 from {req_url} after 60 seconds. Exiting...") | ||
|
|
||
| if check404: |
There was a problem hiding this comment.
Woudl it make sense to put the status checks in a function and thus remove if...else completely? something like that
for _ in range(60):
resp = requests.get(req_url, headers=headers, verify=False)
if checkRespStatus(check404):
print(f"After {_} retries at 1 second interval, got {resp.status_code} response. Continue with tests...")
return
time.sleep(1)
pytest.fail(f"Keep getting {resp.status_code} from {req_url} after 60 seconds. Exiting...")
There was a problem hiding this comment.
I'd agree with the sentiment, the code in the loops are very similar.
They could be combined using with:
if resp.status_code not in valid_codes:
and from there either use wrapping functions or params to setup valid_codes.
soneillf5
reviewed
May 26, 2021
| print("------------- Run test for AP policy: file-block --------------") | ||
| print(f"Request URL: {backend_setup.req_url} and Host: {backend_setup.ingress_host}") | ||
|
|
||
| wait_before_test(40) | ||
| ensure_response_from_backend(backend_setup.req_url, backend_setup.ingress_host) | ||
| ensure_response_from_backend(backend_setup.req_url, backend_setup.ingress_host, check404=True) |
There was a problem hiding this comment.
it's nice to see the wait removed :D
soneillf5
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist
Before creating a PR, run through this checklist and mark each as complete.
suite/test_app_protect.py::TestAppProtect::test_responses_csrf[backend_setup0-crd_ingress_controller_with_ap0] PASSED [ 21%]