Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/fix nightly image #1636

Merged
merged 3 commits into from May 27, 2021
Merged

Chore/fix nightly image #1636

merged 3 commits into from May 27, 2021

Conversation

ciarams87
Copy link
Member

Proposed changes

Fix nightly smoke tests (incorrect image name was being passed)

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@ciarams87 ciarams87 enabled auto-merge (squash) May 27, 2021 10:05
@ciarams87 ciarams87 merged commit 80dca81 into master May 27, 2021
@ciarams87 ciarams87 deleted the chore/fix-nightly-image branch May 27, 2021 10:42
@ciarams87 ciarams87 added the chore Pull requests for routine tasks label Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@soneillf5 soneillf5 soneillf5 approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ciarams87 @vepatel @soneillf5