Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smoke test for user defined browser AP policy #1638

Merged
merged 1 commit into from May 28, 2021
Merged

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented May 27, 2021

Proposed changes

  • Add smoke test for browser based blocking using AppProtect

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

- name: safari
action: alarm
- name: chrome
action: block
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's not your favourite browser 😆

@vepatel vepatel merged commit 6cb0c8c into master May 28, 2021
@vepatel vepatel deleted the tests/ap-udb branch May 28, 2021 12:02
@lucacome lucacome added the chore Pull requests for routine tasks label Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants