Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change policy update handler to only reload on spec change #1713

Merged
merged 1 commit into from Jul 2, 2021

Conversation

soneillf5
Copy link
Contributor

Proposed changes

At the moment, the update handler for Policy resources uses a 'DeepEquals()' for comparing the old and new Policy, however the scope fo which is too broad, so minor changes such as resource version and status result in an Nginx reload.

This change compares just the 'Spec' of each Policy, so it only causes a reload if config data changes.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@lucacome lucacome added the bug An issue reporting a potential bug label Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants