Increase timeout for golangci-lint and add more linters #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacome
requested review from
pleshakov and
soneillf5
and removed request for
a team
|
@nginxinc/kic If you think there are more linter that we should enable the list is here https://golangci-lint.run/usage/linters/ |
pleshakov
approved these changes
Jul 2, 2021
soneillf5
approved these changes
Jul 2, 2021
jputrino
pushed a commit
that referenced
this pull request
Jul 14, 2021
lucacome
added a commit
that referenced
this pull request
Jul 14, 2021
lucacome
added a commit
that referenced
this pull request
Jul 14, 2021
lucacome
added a commit
that referenced
this pull request
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost aligned with the other repos, the last two left are
reviveandnoctxbut they have a lot of issues.The increased timeout should be useful mostly on the first run when the cache is still not present.