Add GoReleaser config for AWS #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lucacome
commented
Jul 8, 2021
lucacome
commented
- Added configuration for building the binary for AWS with GoReleaser
- Added labels in Dockerfile to identify how the image was built
- Improved error messages for AWS RegisterUsage
- Moved the print of the binary version at the start
lucacome
requested review from
pleshakov,
ciarams87 and
soneillf5
and removed request for
a team
lucacome
force-pushed
the
chore/goreleaser-aws
branch
from
f1b581f
to
857354d
Compare
pleshakov
approved these changes
Jul 8, 2021
There was a problem hiding this comment.
👍
Would it make sense to add an enhancement label, since cmd/nginx-ingress/aws.go and cmd/nginx-ingress/main.go include enhancements? In the future, it'd be better to have those in separate PRs or commits. cc @vepatel for awareness
|
@pleshakov I thought about moving them in separate commits and then forgot somehow, doing it now. 👍 I didn't see it as a feature enhancement since it was just about changing log format or rearranging it (for main) but I'm fine with adding the label. |
lucacome
force-pushed
the
chore/goreleaser-aws
branch
2 times, most recently
from
73f99f5
to
090c016
Compare
soneillf5
approved these changes
Jul 12, 2021
lucacome
force-pushed
the
chore/goreleaser-aws
branch
from
ae6b80a
to
ae49661
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.