Add revive linter with recommended config #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacome
requested review from
ciarams87 and
soneillf5
and removed request for
a team
lucacome
force-pushed
the
chore/add-revive-linter
branch
2 times, most recently
from
e909092
to
0e76f72
Compare
pleshakov
approved these changes
Jul 14, 2021
soneillf5
approved these changes
Jul 14, 2021
lucacome
added a commit
that referenced
this pull request
Jul 14, 2021
lucacome
added a commit
that referenced
this pull request
Jul 14, 2021
lucacome
added a commit
that referenced
this pull request
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding revive linter and enabling golangci-lint to check only for new changes (
new-from-rev: HEAD~) so at least we don't introduce new problems.(There are 41 issues at the moment, but they're mostly in tests and fake managers)