Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed hyperlinks. #1756

Merged
merged 2 commits into from Jul 19, 2021
Merged

Fixed hyperlinks. #1756

merged 2 commits into from Jul 19, 2021

Conversation

pammecrandall
Copy link
Contributor

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@github-actions github-actions bot added bug An issue reporting a potential bug documentation Pull requests/issues for documentation labels Jul 16, 2021
@pammecrandall pammecrandall changed the base branch from master to development July 16, 2021 14:04
@pleshakov pleshakov self-requested a review July 16, 2021 16:01
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pammecrandall

Looks good!

I also noticed a link problem in this table https://docs.nginx.com/nginx-ingress-controller/troubleshooting/troubleshooting-with-app-protect/ Could you fix it as well?

Also, there are two tables that are missing:

Would it make sense to bring back those tables in this PR or a separate PR?

Thanks

@pleshakov
Copy link
Contributor

(I rebased the dev branch against the master to resolve the reported conflicts)

@pammecrandall
Copy link
Contributor Author

@pleshakov Thank you for doing that. I can add the missing table fix in this PR. I set the base branch to development but should it be master?

@jputrino
Copy link
Contributor

It's ok to do it either way - we use development for testing and staging mostly for a preview. I'm fine with merging fixes like this directly into master.

@pammecrandall
Copy link
Contributor Author

@jputrino Okay. Cool. I'll change the base branch to master.

@pleshakov I added the missing table and another one that had been left out so this PR should be good now.

I'm working on the links in https://docs.nginx.com/nginx-ingress-controller/troubleshooting/troubleshooting-with-app-protect/ now and I'll check for missing tables there and nginx app protect docs too. Thanks!

@pammecrandall pammecrandall changed the base branch from development to master July 16, 2021 22:09
@pleshakov pleshakov merged commit a9b0bfe into master Jul 19, 2021
@pleshakov pleshakov deleted the hyperlinks branch July 19, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants