Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CodeQL workflow #1846

Merged
merged 2 commits into from Aug 13, 2021
Merged

Update CodeQL workflow #1846

merged 2 commits into from Aug 13, 2021

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Aug 11, 2021

  • Added check for javascript (files in the docs folder)
  • Added the cancel for the workflow inside the workflow itself (I think it makes it more clear to understand what happens)

@lucacome lucacome requested a review from a team August 11, 2021 00:51
@lucacome lucacome self-assigned this Aug 11, 2021
@lucacome lucacome requested review from ciarams87 and soneillf5 and removed request for a team August 11, 2021 00:51
@github-actions github-actions bot added the chore Pull requests for routine tasks label Aug 11, 2021
@lucacome lucacome enabled auto-merge (squash) August 12, 2021 20:19
@pleshakov
Copy link
Contributor

@lucacome I wonder if we really need JavaScript checking? that code is not developed in our repo, just copied to our repo. So even if a problem is found, it will have to be addressed in a different repo.
cc @jputrino

@jputrino
Copy link
Contributor

@lucacome I wonder if we really need JavaScript checking? that code is not developed in our repo, just copied to our repo. So even if a problem is found, it will have to be addressed in a different repo.
cc @jputrino

Agreed, @pleshakov -- it would be great to have this type of check in the source repo, but I don't think it's needed here.

@lucacome
Copy link
Member Author

@pleshakov I thought it wouldn't hurt to have a check in this repo, since the code is here, but I've removed it.

@lucacome lucacome merged commit 1f0e488 into master Aug 13, 2021
@lucacome lucacome deleted the chore/update-codeql branch August 13, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants