Update tests to use networking.k8s.io/v1 #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
lucacome
force-pushed
the
chore/update-tests-v1
branch
from
6fff932
to
2b535f8
Compare
lucacome
force-pushed
the
chore/update-tests-v1
branch
from
2b535f8
to
f3534b0
Compare
pleshakov
reviewed
Aug 12, 2021
| @@ -29,9 +29,10 @@ run-tests-in-kind: | |||
|
|
|||
| .PHONY: create-kind-cluster | |||
| create-kind-cluster: | |||
| kind create cluster | |||
| $(eval K8S_VERSION=$(shell grep "K8S_VERSION:" ../.github/workflows/edge.yml | awk -F" " '{print $$2}')) | |||
|
|
||
| COPY tests /workspace/tests | ||
| COPY deployments /workspace/deployments | ||
|
|
||
| ENTRYPOINT ["python3", "-m", "pytest"] | ||
| ENTRYPOINT ["python3", "-m", "pytest", "suite/"] |
There was a problem hiding this comment.
installing kubernetes from github will pull the src folder and pytest will run the tests for the library too
pleshakov
approved these changes
Aug 12, 2021
lucacome
force-pushed
the
chore/update-tests-v1
branch
from
ce05ac0
to
6d0b3d3
Compare
soneillf5
approved these changes
Aug 13, 2021
vepatel
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to use k8s client version coming from this brach https://github.com/kubernetes-client/python/commits/release-19.0 that has the new v1 API