AP: enable FQDN as syslog destination #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafwegv
force-pushed
the
ap-fqdn-logdst
branch
from
9f2980d
to
e245fd0
Compare
nginx-bot
force-pushed
the
ap-fqdn-logdst
branch
13 times, most recently
from
aa36fb6
to
3cd26ce
Compare
nginx-bot
force-pushed
the
ap-fqdn-logdst
branch
8 times, most recently
from
ca25f78
to
3203d01
Compare
nginx-bot
force-pushed
the
ap-fqdn-logdst
branch
5 times, most recently
from
013a8bc
to
0bdd080
Compare
nginx-bot
force-pushed
the
ap-fqdn-logdst
branch
4 times, most recently
from
df77910
to
d374f0e
Compare
nginx-bot
force-pushed
the
ap-fqdn-logdst
branch
3 times, most recently
from
092c0b3
to
666be2a
Compare
pleshakov
reviewed
Nov 5, 2021
There was a problem hiding this comment.
Hi @rafwegv
Please see my comments
Additionally:
(1) Shall we update the doc for the logDest field of the WAF Policy? (https://docs.nginx.com/nginx-ingress-controller/configuration/policy-resource/#waf). the annotation doc seems fines.
(2) Would it be possible to update and simplify the AppProtect tests so that they no longer rely on fetching the svc IP address, but rather use the DNS name?
nginx-bot
force-pushed
the
ap-fqdn-logdst
branch
9 times, most recently
from
646789a
to
efbcccc
Compare
rafwegv
force-pushed
the
ap-fqdn-logdst
branch
from
efbcccc
to
9987ee2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add checks that enable an FQDN be specified as the destination for security logs
Checklist
Before creating a PR, run through this checklist and mark each as complete.