Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use k8s version in the filename for nightly tests #1968

Merged
merged 3 commits into from Sep 16, 2021

Conversation

lucacome
Copy link
Member

The nightly doesn't have a marker and the action to upload results was having issues with that, so we can use k8s instead.

@lucacome lucacome requested a review from a team September 15, 2021 19:49
@lucacome lucacome self-assigned this Sep 15, 2021
@lucacome lucacome requested review from ciarams87, soneillf5, pleshakov and vepatel and removed request for a team September 15, 2021 19:49
@github-actions github-actions bot added the chore Pull requests for routine tasks label Sep 15, 2021
@soneillf5
Copy link
Contributor

Hi Luca,
Can you go into more detail on this change? What requires the marker and why do we use the k8s version?

@vepatel
Copy link
Contributor

vepatel commented Sep 16, 2021

@soneillf5 I think it's a fix for
Screenshot 2021-09-16 at 09 30 01

@lucacome lucacome merged commit 09f43b6 into master Sep 16, 2021
@lucacome lucacome deleted the chore/nightly-test-upload branch September 16, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants