Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grpc error intercept test #2217

Merged
merged 1 commit into from Nov 26, 2021
Merged

Conversation

ciarams87
Copy link
Member

@ciarams87 ciarams87 commented Nov 25, 2021

Proposed changes

We added error intercept location blocks for cases where the upstream is set as gRPC - see https://www.nginx.com/blog/deploying-nginx-plus-as-an-api-gateway-part-3-publishing-grpc-services/#Responding-to-Errors for details. This adds a test to make sure the headers are being applied.

It also updates the test tls cert and key as it was accidentally created with a one month validity.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@github-actions github-actions bot added the chore Pull requests for routine tasks label Nov 25, 2021
@ciarams87 ciarams87 merged commit 160f7ff into master Nov 26, 2021
@ciarams87 ciarams87 deleted the chore/add-grpc-error-intercept-test branch November 26, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants