Chore: add waf vs tests #2227
Merged
Chore: add waf vs tests #2227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soneillf5
reviewed
Nov 30, 2021
| @@ -63,7 +63,6 @@ def fin(): | |||
|
|
|||
| @pytest.mark.vs | |||
| @pytest.mark.smoke | |||
| @pytest.mark.ciara | |||
There was a problem hiding this comment.
haha I do that all the time
There was a problem hiding this comment.
I usually put "@pytest.mark.sean"
soneillf5
approved these changes
Nov 30, 2021
nginx-bot
force-pushed
the
chore/add-ap-vs-tests
branch
2 times, most recently
from
064df95
to
d86c0ec
Compare
pleshakov
approved these changes
Nov 30, 2021
nginx-bot
force-pushed
the
chore/add-ap-vs-tests
branch
from
d86c0ec
to
fbc43df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add tests for using AP WAF policy with gRPC vs upstreams.
(Note: vsr is not covered by this PR)
Checklist
Before creating a PR, run through this checklist and mark each as complete.