tests: add VSR gRPC WAF tests #2262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nginx-bot
force-pushed
the
add-grpc-vsr-tests
branch
from
e33d8f7
to
31f8500
Compare
|
Note - the AP tests are failing with known failures outside of this PR - the tests introduced by this commit can be seen passing here: https://gitlab.com/f5/nginx/kic/kubernetes-ingress/-/jobs/1868639225#L4814 |
soneillf5
approved these changes
Dec 10, 2021
vepatel
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add VSR gRPC WAF tests. Uses case insensitive regex for the subroute as we can't set capitals in subdomains (throws a validation error - see https://pkg.go.dev/k8s.io/apimachinery@v0.22.4/pkg/util/validation#IsDNS1123Subdomain) but the gRPC client sends a request to "helloworld.Greeter/SayHello".
Checklist
Before creating a PR, run through this checklist and mark each as complete.