Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP: Fix sec log tests #2268

Merged
merged 1 commit into from Dec 13, 2021
Merged

AP: Fix sec log tests #2268

merged 1 commit into from Dec 13, 2021

Conversation

rafwegv
Copy link
Contributor

@rafwegv rafwegv commented Dec 13, 2021

Proposed changes

Set the protocol of syslog service to TCP

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@rafwegv rafwegv added the tests Pull requests that update tests label Dec 13, 2021
@rafwegv rafwegv self-assigned this Dec 13, 2021
@github-actions github-actions bot added the bug An issue reporting a potential bug label Dec 13, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #2268 (f80062d) into master (22c967b) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2268      +/-   ##
==========================================
- Coverage   53.36%   53.35%   -0.02%     
==========================================
  Files          43       43              
  Lines       13413    13409       -4     
==========================================
- Hits         7158     7154       -4     
  Misses       6024     6024              
  Partials      231      231              
Impacted Files Coverage Δ
pkg/apis/configuration/validation/policy.go 95.39% <0.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22c967b...f80062d. Read the comment docs.

@ciarams87 ciarams87 merged commit 9197648 into master Dec 13, 2021
@ciarams87 ciarams87 deleted the ap-fix-tests branch December 13, 2021 18:01
@lucacome lucacome removed the bug An issue reporting a potential bug label Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants