Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update-codegen needs a specific path #2270

Merged
merged 2 commits into from Dec 16, 2021
Merged

Update-codegen needs a specific path #2270

merged 2 commits into from Dec 16, 2021

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Dec 14, 2021

The script only works if the path is exactly the same as the API, this moves the folder to the right place so we can catch changes.

@lucacome lucacome marked this pull request as draft December 14, 2021 02:41
@github-actions github-actions bot added the chore Pull requests for routine tasks label Dec 14, 2021
@lucacome lucacome force-pushed the chore/codegen branch 7 times, most recently from 959091a to 524e6d6 Compare December 14, 2021 03:04
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2021

Codecov Report

Merging #2270 (e359cae) into master (4666d46) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head e359cae differs from pull request most recent head 6a9008d. Consider uploading reports for the commit 6a9008d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2270      +/-   ##
==========================================
- Coverage   53.39%   53.35%   -0.05%     
==========================================
  Files          43       43              
  Lines       13412    13409       -3     
==========================================
- Hits         7161     7154       -7     
- Misses       6022     6024       +2     
- Partials      229      231       +2     
Impacted Files Coverage Δ
internal/k8s/configuration.go 95.65% <0.00%> (-0.39%) ⬇️
internal/configs/virtualserver.go 95.20% <0.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4666d46...6a9008d. Read the comment docs.

@lucacome lucacome force-pushed the chore/codegen branch 20 times, most recently from 2fdb997 to 562535b Compare December 14, 2021 05:41
@lucacome lucacome force-pushed the chore/codegen branch 6 times, most recently from 6f33735 to f945abc Compare December 14, 2021 06:21
@lucacome lucacome mentioned this pull request Dec 14, 2021
@lucacome lucacome marked this pull request as ready for review December 14, 2021 06:29
@pleshakov
Copy link
Contributor

@lucacome looks like the CI is failing

@lucacome lucacome force-pushed the chore/codegen branch 7 times, most recently from f8c1cdf to b27777e Compare December 15, 2021 03:14
@lucacome
Copy link
Member Author

@lucacome looks like the CI is failing

@pleshakov there was an extra . that made it fail 😭, fixed!

@pleshakov
Copy link
Contributor

@lucacome
Copy link
Member Author

lol nice catch @pleshakov

@lucacome lucacome merged commit 27b41da into master Dec 16, 2021
@lucacome lucacome deleted the chore/codegen branch December 16, 2021 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants