Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing ap tests validation DOS override #2292

Merged
merged 1 commit into from Dec 17, 2021
Merged

fixing ap tests validation DOS override #2292

merged 1 commit into from Dec 17, 2021

Conversation

soneillf5
Copy link
Contributor

Proposed changes

DOs feature accidentally changed some common AP validation functions. This PR fixes them and the breaking tests.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@github-actions github-actions bot added the bug An issue reporting a potential bug label Dec 17, 2021
@ciarams87 ciarams87 merged commit 0989945 into master Dec 17, 2021
@ciarams87 ciarams87 deleted the fix-ap-common-validation-test branch December 17, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

@vepatel vepatel vepatel approved these changes

Assignees
No one assigned
Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@soneillf5 @ciarams87 @vepatel