Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP fix reference checker #2314

Merged
merged 1 commit into from
Dec 31, 2021
Merged

AP fix reference checker #2314

merged 1 commit into from
Dec 31, 2021

Conversation

rafwegv
Copy link
Contributor

@rafwegv rafwegv commented Dec 30, 2021

Proposed changes

Fix reference checker for App Protect resources

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@rafwegv rafwegv added the bug An issue reporting a potential bug label Dec 30, 2021
@rafwegv rafwegv self-assigned this Dec 30, 2021
@lucacome lucacome changed the base branch from master to release-2.1 December 31, 2021 18:09
@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2021

Codecov Report

❗ No coverage uploaded for pull request base (release-2.1@1aeb1e0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-2.1    #2314   +/-   ##
==============================================
  Coverage               ?   53.66%           
==============================================
  Files                  ?       48           
  Lines                  ?    14201           
  Branches               ?        0           
==============================================
  Hits                   ?     7621           
  Misses                 ?     6340           
  Partials               ?      240           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aeb1e0...9a10418. Read the comment docs.

@lucacome lucacome merged commit f0ed2e1 into release-2.1 Dec 31, 2021
@lucacome lucacome deleted the ap-fix-ref-checker branch December 31, 2021 21:56
ciarams87 pushed a commit that referenced this pull request Jan 4, 2022
Co-authored-by: Rafal Wegrzycki <r.wegrzycki@f5.com>
lucacome added a commit that referenced this pull request Jan 6, 2022
* Run CI on PRs to release branch (#2300)

* Update Docker image version for Plus (#2302)

* Update docs for new registries (#2301)

* Bump nginx from 1.21.4 to 1.21.5 in /build (#2309)

Bumps nginx from 1.21.4 to 1.21.5.

---
updated-dependencies:
- dependency-name: nginx
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump library/nginx from 1.21.4-alpine to 1.21.5-alpine in /build (#2311)

Bumps library/nginx from 1.21.4-alpine to 1.21.5-alpine.

---
updated-dependencies:
- dependency-name: library/nginx
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump opentracing/nginx-opentracing from nginx-1.21.4 to nginx-1.21.5 in /build (#2310)

Bumps opentracing/nginx-opentracing from nginx-1.21.4 to nginx-1.21.5.

---
updated-dependencies:
- dependency-name: opentracing/nginx-opentracing
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix opentracing for Alpine

* AP fix reference checker (#2314)

Co-authored-by: Rafal Wegrzycki <r.wegrzycki@f5.com>

* Release 2.1.0

Update to 2.1.0

supported versions

Update arbitrator chart for release

Apply suggestions from code review

Co-authored-by: Ciara Stacke <18287516+ciarams87@users.noreply.github.com>
overview

add dos images

fix version

Update docs/content/releases.md

Co-authored-by: Michael Pleshakov <pleshakov@users.noreply.github.com>
fix overview

* Fix goreleaser

* Revert "Upload NGINX Ingress Controller binaries to release (#2044)"

This reverts commit 26715f7.

Co-authored-by: Luca Comellini <luca.com@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: rafwegv <45798029+rafwegv@users.noreply.github.com>
Co-authored-by: Rafal Wegrzycki <r.wegrzycki@f5.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants